History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SAK-11726
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Huong Nguyen
Reporter: Karen Tsao
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sakai

Performance issue when click on Assessments link

Created: 27-Sep-2007 00:05   Updated: 23-Oct-2008 06:30
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 2.4.0, 2.4.1
Fix Version/s: 2.5.0, 2.4.x

Time Tracking:
Not Specified

2.4.x Status: Resolved
2.5.x Status: None
2.6.x Status: None


 Description  « Hide
This is reported by Kyong from Foothill:

I had a question on a troublesome Samigo query.
This is probably the most prevalent query in our slow query log.

select assessment0_.PUBLISHEDASSESSMENTID as col_0_0_,
count(assessment0_.ASSESSMENTGRADINGID) as col_1_0_ from
SAM_ASSESSMENTGRADING_T assessment0_ where assessment0_.FORGRADE=1
group by assessment0_.PUBLISHEDASSESSMENTID;

It's issued once every time Assessments link is clicked as an instructor.

Is it taking submission counts for every published test?
I don't really know how the resulting rows are used but it's quite
heavy since we have 320,000+ rows in SAM_ASSESSMENTGRADING_T.


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Karen Tsao - 09-Oct-2007 10:31
After discussion, we decide to fine tune the query (joining with sam_authzdata_t table):

commit -m "SAK-11726" C:/sakai/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/AssessmentGradingFacadeQueries.java
    Sending sakai/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/AssessmentGradingFacadeQueries.java
    Transmitting file data ...
    Committed revision 36617.

Karen Tsao - 09-Oct-2007 10:33
Huong,
This fix is for performance. Please verify the assessment list page have the correct core, active, and inactive assessments. Thanks.

Also, after you verify, could you please re-assign back to me. I would like to merge it into 2.4.x and 2.5.x. Thanks.

Megan May - 12-Oct-2007 10:51
in .007 tag

Huong Nguyen - 24-Oct-2007 09:50
Karen, this bug has been verified : the assessment page list is working fine. As per your request, I am reassigning it to you. Please close it when you are done patching.
Thanks,
Huong

Karen Tsao - 24-Oct-2007 13:53
Fix for 2.4.x:
$ svn commit -m "SAK-11726"
Sending samigo-services\src\java\org\sakaiproject\tool\assessment\facade\AssessmentGradingFacadeQueries.java
Transmitting file data .
Committed revision 37368.