History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SAK-10304
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Huong Nguyen
Reporter: Lydia Li
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Sakai

Statistics do not count all responses

Created: 02-Jun-2007 12:49   Updated: 23-Oct-2008 08:50
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 2.1.2, 2.2.0, 2.2.1, 2.3.0, 2.2.2, 2.4.0, 2.3.1, 2.2.3, 2.3.2, 2.4.1
Fix Version/s: 2.3.x, 2.5.0, 2.4.x

Time Tracking:
Not Specified

Issue Links:
Duplicate
 

2.4.x Status: Resolved
2.5.x Status: None
2.6.x Status: None


 Description  « Hide
Date: Thu, 24 May 2007 08:05:14 +0200
From: "Gregory Doyle" <Gregory.Doyle@uct.ac.za>

Hi
Not sure if anyone has come across this before.
Published a quiz (7 parts, no question pools involve, every question 0
marks, anonymous grading, not send to gradebook, 1 submission only etc)


On the Statistics page, (Viewing All Submissions) number of submissions
= 348 but the responses for the MCQ and Short Answer questions add up to
around 238 only. So what happened to the other 110 responses?


Went to the questions page and checked individual questions, there are
348 responses (copy and pasted to Excel to make sure its correct, and it
is)


Any ideas?


Thanks
greg


Date: Sat, 02 Jun 2007 09:40:54 +0200
From: Stephen Marquard <stephen.marquard@uct.ac.za>

Karen Tsao wrote:
Hi Stephen,
Thanks for providing these information. I think I know where it goes wrong.
In AssessmentGradingFacadeQueries.java, there is a line:
criteria.setMaxResults(10000)
It restricts/truncate the returning data. Lydia said this is added by Indiana U in 2.1.
There is one comment explains the reason to set the max results:
//large list cause out of memory error (java heap space)
However, we don't even know if we will still get this error for later version
because Sakai requires larger the heap size now. Could you please help me to
try it out? Just change
return criteria.setMaxResults(10000).list();
to
return criteria.list();
Please let me know if you get out of memory error. If not, please let me know if the
statistics page looks fine..


Hi Karen


That seems to fix it, and we didn't get any out of memory errors in catalina.out. Our JAVA_OPTS are


-server -Xmx1200m -XX:MaxPermSize=256m -XX:+UseAdaptiveSizePolicy -XX:GCTimeRatio=49 -XX:ThreadStackSize=256

Could you get this fix into the 2-4-x branch as well as trunk?


Cheers
Stephen




 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Karen Tsao - 04-Jun-2007 15:28
commit -m "SAK-10194" C:/sakai/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/AssessmentGradingFacadeQueries.java
    Sending sakai/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/AssessmentGradingFacadeQueries.java
    Transmitting file data ...
    Committed revision 31390.

Karen Tsao - 05-Jun-2007 10:36
$ svn propset --revprop -r31390 svn:log "SAK-10304"
property 'svn:log' set on repository revision 31390

Karen Tsao - 05-Jun-2007 10:36
For 2-4-x:

$ svn commit -m "SAK-10304"
Sending samigo-services\src\java\org\sakaiproject\tool\assessment\facade\
AssessmentGradingFacadeQueries.java
Transmitting file data .
Committed revision 31414.

Karen Tsao - 05-Jun-2007 10:38
Huong,

There is no function/behavior changes. To verify this fix, please make sure you see the same statistics result as before.

Thanks.

Karen Tsao - 05-Jun-2007 17:02
For 2.3.x:
$ svn commit -m "SAK-10304"
Sending facade\AssessmentGradingFacadeQueries.java
Transmitting file data .
Committed revision 31434.

Huong Nguyen - 21-Sep-2007 12:53
Everything in statistics seems to be fine tome. Verified on qa3-us