[#SAK-10153] Performance Improvement - Clean up unecessary queries against SAM_PUBLISHEDANSWERFEEDBACK_T and SAM_PUBLISHEDITEMMETADATA_T (in delivery flow)

Sakai

Performance Improvement - Clean up unecessary queries against SAM_PUBLISHEDANSWERFEEDBACK_T and SAM_PUBLISHEDITEMMETADATA_T (in delivery flow)

Created: 22-May-2007 17:19 Updated: 23-Oct-2008 08:49

Component/s:

Tests & Quizzes (Samigo)

Affects Version/s:

2.4.0, 2.4.1

Fix Version/s:

2.5.0, 2.4.x

Time Tracking:

Not Specified

2.4.x Status:	Resolved
2.5.x Status:	None
2.6.x Status:	None

Description

« Hide

During the load testing at UMich, we have found that the following two queries were executed intensively during delivery. Will need to analyze if hibernate objects are getting loaded unnecessarily.

select answerfeed0_.ANSWERID as ANSWERID1_,answerfeed0_.ANSWERFEEDBACKID as ANSWERFE1_1_,
            answerfeed0_.ANSWERFEEDBACKID as ANSWERFE1_137_0_, answerfeed0_.ANSWERID as ANSWERID137_0_,
            answerfeed0_.TYPEID as TYPEID137_0_, answerfeed0_.TEXT as TEXT137_0_
from SAM_PUBLISHEDANSWERFEEDBACK_T answerfeed0_
where answerfeed0_.ANSWERID=:1

select itemmetada0_.ITEMID as ITEMID1_, itemmetada0_.ITEMMETADATAID as ITEMMETA1_1_,
            itemmetada0_.ITEMMETADATAID as ITEMMETA1_134_0_, itemmetada0_.ITEMID as ITEMID134_0_,
            itemmetada0_.LABEL as LABEL134_0_, itemmetada0_.ENTRY as ENTRY134_0_
from SAM_PUBLISHEDITEMMETADATA_T itemmetada0_
where itemmetada0_.ITEMID=:1

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Karen Tsao - 22-May-2007 17:21

The reason is we make a call to PublishedAssessmentFacadeQueries.getPublishedAssessment() for every item (question) in the site. I will fix this by avoiding this.

[ Permlink | « Hide ]

Karen Tsao - 23-May-2007 10:32

commit -m "~~SAK-10153~~" C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/select/SelectActionListener.java C:/sakai/sam/samigo-hibernate/src/java/org/sakaiproject/tool/assessment/data/dao/assessment/PublishedAssessmentData.java C:/sakai/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/PublishedAssessmentFacade.java C:/sakai/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/PublishedAssessmentFacadeQueries.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/select/SelectActionListener.java
    Sending sakai/sam/samigo-hibernate/src/java/org/sakaiproject/tool/assessment/data/dao/assessment/PublishedAssessmentData.java
    Sending sakai/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/PublishedAssessmentFacade.java
    Sending sakai/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/PublishedAssessmentFacadeQueries.java
    Transmitting file data ...
    Committed revision 30963.

[ Permlink | « Hide ]

Karen Tsao - 25-May-2007 10:15

To verify this fix, please make sure everything works the same as before. Thanks.

[ Permlink | « Hide ]

Karen Tsao - 25-May-2007 10:30

Huong,

Please pay more attention on the submitted assessment list. Something like whether the highest or the last submission should be see (depending on the assessment setting). The "*" should be displayed correctly next to certain submissions. Something like these. You might be able to think of more.

Thanks.

[ Permlink | « Hide ]

Huong Nguyen - 29-May-2007 10:55

Verified on nightly: http://coursework-s1.stanford.edu:28080/portal, everything worked fine.

[ Permlink | « Hide ]

Karen Tsao - 06-Jun-2007 15:34

Fix for 2.4.x:

$ svn commit -m "~~SAK-10153~~"
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\ui\listener\select\SelectActionListener.java
Sending samigo-hibernate\src\java\org\sakaiproject\tool\assessment\data\dao\assessment\PublishedAssessmentData.java
Sending samigo-services\src\java\org\sakaiproject\tool\assessment\facade\PublishedAssessmentFacade.java
Sending samigo-services\src\java\org\sakaiproject\tool\assessment\facade\PublishedAssessmentFacadeQueries.java
Transmitting file data ....
Committed revision 31482.

[ Permlink | « Hide ]

Huong Nguyen - 30-Oct-2007 10:13

Done regression test, everything seems working fine. So I close this.