History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SAK-10020
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Huong Nguyen
Reporter: Diego del Blanco Orobitg
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Sakai

Delivery dates in samigo can accept invalid dates without any message

Created: 15-May-2007 03:04   Updated: 23-Oct-2008 08:50
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 2.4.0, 2.4.1
Fix Version/s: 2.5.0, 2.4.x

Time Tracking:
Not Specified

2.4.x Status: Resolved
2.5.x Status: None
2.6.x Status: None


 Description  « Hide
The problem is with delivery dates in settings.

If you insert a valid date it works fine... but try to insert an invalid date as 15/15/2007

System thinks that 15 months are 12 + 3 months, so it changes at 03/15/2008... And it saves it perfectly and don't displays any error message. I think system must display a error message in that point, isn't it?

This problen will be bigger in places where teachers use the dd/mm/yyyy format. Sample: If a teacher tries to insert a date as 30/06/2007 it becomes a date in 2009!!!

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Diego del Blanco Orobitg - 15-May-2007 03:14
The same happens with Feedbak release date

Megan May - 16-May-2007 08:22
Dropping the severity of this to critical as this doesn't prevent the use of a tool or result in data loss

Karen Tsao - 21-May-2007 14:44
commit -m "SAK-10020" C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/GeneralMessages_es.properties C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/GeneralMessages.properties C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/jsf/renderer/DatePickerRenderer.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/PublishedAssessmentSettingsBean.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/AuthorSettingsListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/EditPublishedSettingsListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettingsListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java C:/sakai/sam/samigo-app/src/webapp/jsf/widget/datepicker/datepicker.js
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/GeneralMessages.properties
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/GeneralMessages_es.properties
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/jsf/renderer/DatePickerRenderer.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/PublishedAssessmentSettingsBean.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/AuthorSettingsListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/EditPublishedSettingsListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettingsListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
    Sending sakai/sam/samigo-app/src/webapp/jsf/widget/datepicker/datepicker.js
    Transmitting file data ...
    Committed revision 30862.

Karen Tsao - 25-May-2007 10:12
In addition to the validation, I actually made the date picker returns the desired format based on user language. Therefore, there are two features to be verified here:

1. Put in date in various incorrect format and see if data is not saved and error message is displayed.
2. Change user preference language between English and Spanish (this is the one has correct properties set). Make sure the date is displayed and saved correctly.

Karen Tsao - 25-May-2007 10:13
Diego has already helped us verifying in Spanish.

Huong Nguyen - 29-May-2007 10:35
Verified on nightly instance, there is a validationfor invalid date now.

Karen Tsao - 06-Jun-2007 15:29
Fix for 2.4.x:

$ svn commit -m "SAK-10020"
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\bundle\GeneralMessages.properties
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\bundle\GeneralMessages_es.properties
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\jsf\renderer\DatePickerRenderer.java
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\ui\bean\author\AssessmentSettingsBean.java
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\ui\bean\author\PublishedAssessmentSettingsBean.java
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\ui\listener\author\AuthorSettingsListener.java
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\ui\listener\author\EditPublishedSettingsListener.java
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\ui\listener\author\SaveAssessmentSettingsListener.java
Sending samigo-app\src\java\org\sakaiproject\tool\assessment\ui\listener\author\SavePublishedSettingsListener.java
Sending samigo-app\src\webapp\jsf\widget\datepicker\datepicker.js
Transmitting file data ..........
Committed revision 31481.

Megan May - 29-Jul-2007 12:28
Given Diego has testing scenerio #2 (2. Change user preference language between English and Spanish (this is the one has correct properties set). Make sure the date is displayed and saved correctly. ), Huong tested this on nightly and I've verified this on a 2.4.x instance, I think we can close this one.